tye-v2 / tye2

Tye2 is a local orchestrator tool that makes developing and testing microservices and distributed applications easier.
https://www.tye2.org
MIT License
1 stars 2 forks source link

.Net Foundation info on the top of files #50

Open drakon660 opened 3 months ago

drakon660 commented 3 months ago

Search for:

// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. // See the LICENSE file in the project root for more information.

razvangoga commented 3 months ago

When removing these comments i noticed that some of the classes (especially Tye2.Test.Infrastructure/xunit the ones under like this one https://github.com/tye-v2/tye2/blob/8b04066faedd135156802a7bdd5032a4f3ad11c8/test/Tye2.Test.Infrastructure/xunit/ConditionalTheoryAttribute.cs#L2) are licenced under Apache2.0

I think we need to change the projects licence to Apache2.0 from MIT

I found this about what happeds in mixed licence scenarios : https://dwheeler.com/essays/floss-license-slide.html

It seems the original tye project was mis-licenced: was setup as MIT but had Apache2.0 parts in it => it should have been Apache2.0 as it takes precedence as the more limiting licence type of the two

What do you think?

cc @Mrxx99

drakon660 commented 3 months ago

I would rewrite apache parts to have MIT. MIT is simpler and more permissive, with fewer conditions to follow. I think we can do that?

image

This doesn't have such license. To be honest I wouldn't bother.

razvangoga commented 3 months ago

i don't think you can do that (change the licence)

for apache the comments have to remain it seems https://en.wikipedia.org/wiki/Apache_License#Licensing_conditions

one can add to them if one modifies the file

drakon660 commented 3 months ago

Yes you can.

image

razvangoga commented 3 months ago

i think here by the software then understand the entire project

so we can keep the prj as MIT and the Apache2 files remain as they are now (with the comment)

correct?

drakon660 commented 3 months ago

of course, the issue was related to .net foundation information removal.