search

tygron-virtual-humans / port-gamygdala

Port of Gamygdala from JavaScript to Java
2 stars 3 forks source link

Refactor gamygdala #25

Closed svenvanhal closed 9 years ago

svenvanhal commented 9 years ago

I have refactored the Gamygdala class.

The helper / facilitator methods now reside in their own class (Engine), while the core Gamygdala functionality remains in Gamygdala. This preserves the ease of use from the Javascript version, but simultaneously allows us to follow and implement Java design patterns.

Fixes #18.

svenvanhal commented 9 years ago

Issues to resolve before ready to merge with master: #26, #27.

svenvanhal commented 9 years ago

I believe this is ready for release. Test coverage is at 79,9%.

Fixes #18. Fixes #26. Fixes #27.

nordinvannes commented 9 years ago

This refactor looks wonderfull! Much better than the original port.

trensen commented 9 years ago

Keywords like Fixes don't work in comments, only in a PR's description. :wink: