Closed tyhoff closed 10 years ago
while we have a clean up branch, I say we go ahead and remove any commented out code, minus any debugging log statements that we could need for future development. I think there's some in the javascript, if I remember correctly.
I’m actually planning on adding MORE debug statements lol. It saved our ass, so might as well abuse them. I’ll remove unused code.
On Apr 15, 2014, at 6:09 PM, Scott Opell notifications@github.com wrote:
while we have a clean up branch, I say we go ahead and remove any commented out code, minus any debugging log statements that we could need for future development. I think there's some in the javascript, if I remember correctly.
— Reply to this email directly or view it on GitHub.
Can we have a flag to turn on these debug statements instead of commenting and uncommenting?
On Tue, Apr 15, 2014 at 6:10 PM, Tyler Hoffman notifications@github.comwrote:
I'm actually planning on adding MORE debug statements lol. It saved our ass, so might as well abuse them. I'll remove unused code.
On Apr 15, 2014, at 6:09 PM, Scott Opell notifications@github.com wrote:
while we have a clean up branch, I say we go ahead and remove any commented out code, minus any debugging log statements that we could need for future development. I think there's some in the javascript, if I remember correctly.
Reply to this email directly or view it on GitHub.
Reply to this email directly or view it on GitHubhttps://github.com/tyhoff/Clock/pull/5#issuecomment-40540776 .
Kirby Associate Director of BoilerMake http://boilermake.org/
Oh I agree. I meant to not remove any debug statements. Does pebble have a way to conditionally execute logs only during dev? Not that its a big deal, but it would be a good idea if pebble has a way to do it.
I’m checking into it now.
http://forums.getpebble.com/discussion/10365/pebble-build-command-line-arguments
On Apr 15, 2014, at 6:14 PM, Scott Opell notifications@github.com wrote:
Oh I agree. I meant to not remove any debug statements. Does pebble have a way to conditionally execute logs only during dev? Not that its a big deal, but it would be a good idea if pebble has a way to do it.
— Reply to this email directly or view it on GitHub.
Just leave them all in, if anything ever goes wrong we'll have the option to get emailed logs I believe, so we want as much information while debugging.
Yeah I say just keep them in. They won't hurt anything. They are stored on the phone so it doesn't really take away performance on the Pebble
This got too unorganized for me. I'm going to split it up into separate issues and more distinct commits.
Silly changes. Fixes #3