tyiannak / multimodal_movie_analysis

A Python Library for Multimodal Analysis of Movies and Content-based Movie Recommendation
25 stars 8 forks source link

Code refactoring #5 #7

Closed pakoromilas closed 3 years ago

pakoromilas commented 3 years ago

Code refactoring is probably done.

Things done:

  1. Made code PEP8 compliant
  2. Created 11 functions :
    • display_histogram
    • initialize_face
    • remove_overlaps
    • seconds_to_time
    • color_analysis
    • update_faces
    • shot_change
    • calc_shot_duration
    • windows_display
    • get_features_stats
    • display_time
  3. Removed 2 functions:
    • drawArrow : replaced with cv2.arrowedLine command
    • anglesCluster : it was not used
  4. Modified some parts of the rest of the code to make it more efficient
  5. Wrote docstrings for every function and for the module itself.

Things to consider: A banch of functions are not used or work properly at the time.

@tyiannak , @theopsall and @apoman38 please take a look at the code and tell me if everything looks and works fine. For any question you can ask me in the comments, or read the docstrings provided to the functions.

tyiannak commented 3 years ago

Let's keep dirs_process_video and npy_to_csv (even though they are not used) and remove the rest (get_hsv_histograms_2d, analyze / script debug)

pakoromilas commented 3 years ago

Let's keep dirs_process_video and npy_to_csv (even though they are not used) and remove the rest (get_hsv_histograms_2d, analyze / script debug)

Done.

pakoromilas commented 3 years ago

@tyiannak thank you for the feedback. I managed all of your proposed changes. If you find any more issues with this branch , I would like to resolve them.