tyiannak / pyAudioAnalysis

Python Audio Analysis Library: Feature Extraction, Classification, Segmentation and Applications
Apache License 2.0
5.76k stars 1.18k forks source link

Feature extraction: no windowing function applied #305

Open tluocs opened 3 years ago

tluocs commented 3 years ago

In short term feature_extraction(), there is no windowing function applied. However, Hamming window (or sometimes Kaiser window) is typically used to counter the boundary effect. Should this be added to the code? Seems to be quite important.

In fact, in the same file there is a function called phormants() which does call np.hamming(), but this phormants() function is never used and this strange function name does not seem to give any clue what it does.