search

tyiannak / pyAudioAnalysis

Python Audio Analysis Library: Feature Extraction, Classification, Segmentation and Applications
Apache License 2.0
5.88k stars 1.2k forks source link

Use of eyed3 in pyAudioAnalysis #342

Open mdinescu opened 3 years ago

mdinescu commented 3 years ago

This is a question about the license to use pyAudioAnalysis which is currently published under Apache 2.0. The library makes use of the eyeD3 library for reading ID3 tags, which is published under GPLv3.

I was wondering if you'd be willing to accept a pull request to replace the current use of eyeD3 with mutagen which is published under GPLv2, or with STagger which is published under BSD license. Mutagen supports more types of metadata.

Looks like the only use of eyeD3 is in the audioBasicIO class https://github.com/tyiannak/pyAudioAnalysis/blob/a16ca2da5b0a6897c7573a56e747e57cd8e14a3c/pyAudioAnalysis/audioBasicIO.py

I've checked all the other dependencies and the only one that uses GPLv3 is eyeD3.

slowglow commented 3 years ago

Indeed, I think it makes sense. Upvoted.

tyiannak commented 3 years ago

That makes perfect sense thank you for that, I've used mutagen in the past, never STagger. So a PR would be great thanx!

slowglow commented 3 years ago

BSD license, if possible, please. Unrestrictive OS licenses go together well. Restrictive OS licenses go together well too. Mixing, not so well. So, please, consider GPL in this case only if implementation is overwhelmingly superior and as an option at that.

tyiannak commented 3 years ago

Sure, let's prefer BSD, I just said I had not used stagger before.