search

tykeal / ep_ldapauth

(Up for adoption) LDAP authentication plugin for Etherpad-lite
GNU General Public License v2.0
25 stars 20 forks source link

Skip admin binding if searchDN is not defined #31

Closed sergiik closed 7 years ago

sergiik commented 7 years ago

For anonymous ldap access it's enough just to omit searchDN option in settings.json

tykeal commented 7 years ago

Greetings @sergiik I finally got a chance to give this a try. It still fails because there's an assertion for opts.adminDn in lib/MyLdapAuth.js

I'll merge this if you update your change to remove the assertion and also give me a Signed-off-by line ( http://developercertificate.org/ )

sergiik commented 7 years ago

Hello @tykeal and thanks for your response.

I've updated the change as you suggested. Please check if it's ok now.