search

tykeal / ep_ldapauth

(Up for adoption) LDAP authentication plugin for Etherpad-lite
GNU General Public License v2.0
25 stars 20 forks source link

Adjust to newer behavior of 'getAuthor4Token' #45

Closed hihiuztrewq closed 3 years ago

hihiuztrewq commented 3 years ago

I experienced the same error as described in #44

In newer versions of etherpad-lite 'authorManager.getAuthor4Token' does not expect a callback-function anymore. So 'authorManager.setAuthorName' was never executed.

tykeal commented 3 years ago

@hihiuztrewq Need a Signed-off-by line in the commit message on the change. See the details on the DCO bot failure. I won't accept changes without it.

jolly-jump commented 3 years ago

Hi @tykeal , seems to me, @hihiuztrewq signed it off in the commit.

Merge ok?

tykeal commented 3 years ago

@jolly-jump yes, sorry. I totally missed that as a forced push doesn't notify :-/