search

tykeal / ep_ldapauth

(Up for adoption) LDAP authentication plugin for Etherpad-lite
GNU General Public License v2.0
25 stars 20 forks source link

Authorisation don't work #48

Open gjaekel opened 3 years ago

gjaekel commented 3 years ago

I'm a newbie to etherpad. I try to get the LDAP integration running. Authenication is already working, but IMHO authentication seems to have an issue:

Is it possible that the value returned at https://github.com/tykeal/ep_ldapauth/blob/42cd54c8f65ebb4b4c061b682be2acaf5486e0bc/ep_ldapauth.js#L174 should be true?

Because if I change it in this way, all _seems- to work so far. But I have no experience with Etherpad, yet and this change might be complete wrong.

pcworld commented 2 years ago

Maybe try with PR #47 applied. It removes the offending code that you have modified in PR 49.