search

tykeal / puppet-gerrit

Puppet module to manage Gerrit
6 stars 7 forks source link

Add $manage_user, $gerrit_user, and $gerrit_group parameters #12

Closed BobVincentatNCRdotcom closed 8 years ago

BobVincentatNCRdotcom commented 9 years ago

Allow external management of the gerrit user. Also, do not assume that the gerrit group and gerrit user are the same name.

tykeal commented 9 years ago

Useful, but until the current Travis error is resolve it's unmergable. I would also like to see tests validating that passing in user_manage = false is doing the correct thing (I can see that it is, but I like the tests) as well as passing different users / groups does the right thing.

BobVincentatNCRdotcom commented 9 years ago

Corrected the bug; will write tests when I get a chance.

BobVincentatNCRdotcom commented 9 years ago

Yay! Tests pass. Now I only need to write a test for manage_user=false.

tykeal commented 8 years ago

@rvincentatprokarmadotcom looks good now :) Thanks for doing this!