search

tykeal / puppet-gerrit

Puppet module to manage Gerrit
6 stars 7 forks source link

add support for sources to firewall rules #16

Closed jordane closed 8 years ago

jordane commented 8 years ago

I'm happy to add rspec-puppet-facts to the other tests as well, but I just did the test file I changed as a proof-of-concept.

tykeal commented 8 years ago

A couple of things.

1) please amend your commit and add a Signed-off-by line (you can easily do this with git commit -s --amend) 2) The changes you made make this a Puppet4+ only module. As such the metadata.json will have to be updated to indicate this 3) the .travis.yml will need to be updated to remove the puppet version 3.7.5 or this will never pass Travis

jordane commented 8 years ago

@tykeal Done. Thanks!