tyler-johnson / stripe-meteor

A Meteor package containing Stripe.js, Node-Stripe, and Stripe Checkout.
https://atmospherejs.com/mrgalaxy/stripe
150 stars 44 forks source link

Bump version to 3.3.4? #36

Closed dkmooers closed 9 years ago

dkmooers commented 9 years ago

Hey Tyler, can you bump the Stripe API version to 3.3.4? There are some new functions like:

Stripe.customers.createSource()

That are not in 3.2.0. Per Stripe API docs, this is the way to add a card to a customer, using a token.

See new version here w/createSource et. al.:

https://github.com/stripe/stripe-node/search?utf8=%E2%9C%93&q=createSource&type=Code

Thanks!

Ethaan commented 9 years ago

+1

@dkmooers did you find a workaround to use the new 3.3.4 API Version?

dkmooers commented 9 years ago

Yep, stripe-sync has been updated to include Stripe API 3.3.4, no longer depends on another Stripe package. That's what I'm using. Also nice since it has all the API methods pre-wrapped as sync methods on the server!

https://atmospherejs.com/copleykj/stripe-sync

Ethaan commented 9 years ago

Great, i will test it right now

Thanks

Ethaan commented 9 years ago

Qucik question.

How did you deal with the cosole warn.

It looks like Stripe.js was loaded more than one time. Please only load it once per page.?

dkmooers commented 9 years ago

Remove mrgalaxy:stripe from your project and you should be good. copleykj:stripe-sync now includes Stripe javascript libraries.

tyler-johnson commented 9 years ago

I've bumped Stripe to 4.0. Let me know if there are issues.