Please check if your PR fulfills the following requirements:
Tests for the changes have been added/updated: Y
Docs have been added/updated: Y
Does this PR introduce a breaking change? N
I have linked any related GitHub issues to be closed when this PR is merged? N
Describe the new behavior?
The <forge-icon-button> previously incorrectly set its default theme state to "primary" which doesn't allow for the theme to be truly using the "primary" theme color for the icon like the other built-in theme colors do. This was done because by default icon buttons will use currentColor to inherit the color for the icon, but the state layer and focus indicator both use the primary theme.
This change will reduce confusion by setting the default state to "default" instead, which enable the "primary" theme color to naturally just work as expected to fully style it correctly.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
The
<forge-icon-button>
previously incorrectly set its defaulttheme
state to "primary" which doesn't allow for the theme to be truly using the "primary" theme color for the icon like the other built-in theme colors do. This was done because by default icon buttons will usecurrentColor
to inherit the color for the icon, but the state layer and focus indicator both use the primary theme.This change will reduce confusion by setting the default state to "default" instead, which enable the "primary" theme color to naturally just work as expected to fully style it correctly.