tyler-technologies-oss / forge

Framework agnostic Web Component library that implements the Tyler Forge™ design system.
Apache License 2.0
47 stars 13 forks source link

fix(icon-button): fix to properly default `theme` to "default" to allow for "primary" to be used like other themes #644

Closed DRiFTy17 closed 3 months ago

DRiFTy17 commented 4 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

Describe the new behavior?

The <forge-icon-button> previously incorrectly set its default theme state to "primary" which doesn't allow for the theme to be truly using the "primary" theme color for the icon like the other built-in theme colors do. This was done because by default icon buttons will use currentColor to inherit the color for the icon, but the state layer and focus indicator both use the primary theme.

This change will reduce confusion by setting the default state to "default" instead, which enable the "primary" theme color to naturally just work as expected to fully style it correctly.

stackblitz[bot] commented 4 months ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

github-actions[bot] commented 1 month ago

:rocket: PR was released in v3.1.0 :rocket: