tyler314 / led_matrix

Micropython library used to control Adafruit's RGB LED matrix panel.
MIT License
3 stars 1 forks source link

natural color names #7

Open untzag opened 7 years ago

untzag commented 7 years ago

came across (this very simple project)[https://github.com/apoorvaeternity/colory] posted on reddit

made me think that maybe, as a convenience method, we should allow setting of color using natural names

tyler314 commented 7 years ago

We could implement this if you would like, it would just be a matter of hard coding the natural colors as variables in the class. (Recall that the ws2812 goes in GRB order) self.red = 0xff00 self.green = 0xff0000 self.blue = 0xff self.purple = 0x8080 But I still think we should have the option for the user to specify an exact hex color if they choose. Creating these natural colors seems like unnecessary handholding to me, and I don't see why we would do something like this guy did with the nearest_match() method since our LEDs are capable of outputting every hex value from 0x0 to 0xffffff. Limiting the user to only natural colors seems like a disadvantage to me.