Open rfay opened 2 months ago
Still does not have working tests.
Are you still using it in your daily work?
Daily? No.
I have a couple of older projects that use it so its run locally when bugs are reported.
The addon works. The tests do not.
Can I help? I'm currently trying to get it set up on a dev project. I can help update docs and potentially work on tests too. I first need to get by the verification timed out error I'm running into, but with enough googling I'm sure I'll get it.
@UltraBob Thank you for the offer.
I got the tests sorted yesterday. And confirmed it works in a demo project both locally and in Github actions. Will transfer it over when I get a chance.
There's no pressure from me. I don't know how much this is valuable to a wider audience.
@tyler36 thanks for the quick reply! By the way, I was also in Japan (for 24 years) until about a year ago. I finally got this working on the mac, and suggest some changes to the docs around that. What would be the best way to approach that? A pull request?
@rfay it would really be good to have a solution for this around. It seems to be getting more and more traction in Drupal, and is being used for testing Experience Builder.
PRs are welcome; ideally with tests, where possible.
I don't have a mac to test against, but I know that there are many users that are keen to have it working there.
@tyler36 I can set up an amd64 mac for you if you're interested. We have 3 running as test runners but amd64 is not very important now.
I've submitted a PR, but it is just for adding docs about how to get it running on Mac. I'm now working on how to have more than just electron available as a testing browser, and some other config options. As I get a bit more familiar I may be more capable of contributing to tests and other options
It seems this has gotten pretty mature. Should it be promoted to official?