Reposition the Star and Upvote Count to be next to the Reply button

tylerSmithTSS / kinjamprove

https://chrome.google.com/webstore/detail/kinjamprove/ndhbdbmajaaclhoeabpblncclhhfcbpf

4 stars 3 forks source link

Reposition the Star and Upvote Count to be next to the Reply button #4

Open crw opened 7 years ago

crw commented 7 years ago

The basic goal is move the upvote to the left-hand side. UX studies generally show that positioning controls on the left make them more visible and accessible to readers.

I am guessing this will require some javascript work, which may or may not be wise given the already-existing performance issues.

0x263b commented 7 years ago

I've managed to accomplish a few things to make it more Disqus like: https://gist.github.com/0x263b/4515c47f189671cba563ecaf253f09b3

Screenshot of The A.V. Club:

crw commented 7 years ago

Can you create a pull request?

0x263b commented 7 years ago

Would be happy to.

Before I do can I get someone else to test it? I've made a version that can work as a Tampermonkey script to work in Firefox (disable kinjamprove before using it)

https://gist.github.com/0x263b/5407bd4cb97bc5c653bad2d58b4a7f7e

crw commented 7 years ago

I'll get to that today. I actually asked for the pull request so that I could test it. ;) That would let me download the code as a branch and try it out. No worries though, I'll do the needful on my end.

crw commented 7 years ago

This is working pretty well! Two nits:

If you are the first to "star" something, it doesn't show the number (not really a big deal).
The ellipses icon for the "more" menu used to be vertical, now it is horizontal. Again, honestly, not something I care much about.

Tested on macOS/FirefoxDeveloperEdition.

0x263b commented 7 years ago

I rotated the ellipses icon so it looks more at home with the collapse thread buttons.

crw commented 7 years ago

I figured. I'm not a UI expert but something seems off about those icons, but it was worse with the star. It is much better as-is.