search

tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

Added title and message to /expire. #1060

Closed UnspeakableHorror closed 8 years ago

UnspeakableHorror commented 8 years ago

Closes https://github.com/natebenson/vyllage/issues/1057

tylerbenson commented 8 years ago

This is more what I had in mind: https://github.com/natebenson/vyllage/blob/master/assets/src/login.html#L43

This shouldn't require controller changes. If you disagree and prefer this approach, that's fine too.

UnspeakableHorror commented 8 years ago

When I tried using param.something on login it didn't work, I suggested to @tarex doing it that way but since it failed I ended up going for the usual approach.

BUT it seems the dev-watch wasn't working or something, I tried it again after pulling from master, rebuilding and it worked.

Anyway, there's nothing to change then, since there are no other messages there's no point in adding a th:if there right now.

tarex commented 8 years ago

sorry i didn't understand . so do i have to redirect it to specific routes to show that message ? @UnspeakableHorror

UnspeakableHorror commented 8 years ago

Yes, just to /expire. We don't have any other message right now, when we do, we''ll do it like /expire?someParam