search

tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

double objective statement #1079

Closed natebenson closed 9 years ago

natebenson commented 9 years ago

another user screen shot 2015-09-29 at 8 54 33 pm

nelonoel commented 9 years ago

I'm not sure how he was able to do this. If you try adding a non-multiple section and it already exists, it should proceed by editing the existing section. Do you have any ideas on how to reproduce this issue @UnspeakableHorror @tarex?

UnspeakableHorror commented 9 years ago

No idea, I tried and it's not possible, might have been fixed in another PR?

UnspeakableHorror commented 9 years ago

I tried at www.vyllage.com and local.

tylerbenson commented 9 years ago

Perhaps having two windows open?

Probably not the way he did it, but seems possible.

nelonoel commented 9 years ago

@tylerbenson nice. Yeah, that's possible.

UnspeakableHorror commented 9 years ago

Interesting, two windows open allow you to duplicate it, I never though of that. Now how to solve this...

tylerbenson commented 9 years ago

Perhaps do some sort of merge of sections on the back end?

UnspeakableHorror commented 9 years ago

I was thinking of denying it at the controller but since the first section is already saved then yes that could work too.

UnspeakableHorror commented 9 years ago

Of course that will only work for sections that have simple string fields, if we ever have others that are complex with dates, pictures, etc that won't work. Always speaking about sections that admit one per type.

nelonoel commented 9 years ago

Maybe adding a validation to check on single-only sections on the back-end? A quick fix would be to hide that extra section from the front-end.

UnspeakableHorror commented 9 years ago

Yes, for those that are complex we can only reject them. Now, the problem is that the data is already there and there's no easy fix with a script, hmm.

nelonoel commented 9 years ago

Single sections are Objective, Skills and Career Interests. No dates or pictures from their content if you plan to go the merging route.

UnspeakableHorror commented 9 years ago

Ok!

tylerbenson commented 9 years ago

Related to #1064.