Wrong property files being loaded in PROD environment.

tylerbenson / vyllage

https://www.vyllage.com

4 stars 0 forks source link

Wrong property files being loaded in PROD environment. #1094

Closed UnspeakableHorror closed 9 years ago

UnspeakableHorror commented 9 years ago

Fixes https://github.com/natebenson/vyllage/issues/1084. Fixes https://github.com/natebenson/vyllage/issues/1100.

Facebook and Google+ were using the DEV application Ids and password instead of the prod ones because the wrong property files were being loaded.
Removed harcoded base url, let the app create it since it's not the cause of the social network problems.

tylerbenson commented 9 years ago

@UnspeakableHorror Let me know what you think of my changes. Lets shoot to get this merged tomorrow.

Unfortunately I can't run in eclipse anymore as it can't seem to access the dev configs, but at this point I'd rather figure that out later. Runs fine via gradle and foreman.

UnspeakableHorror commented 9 years ago

Yes, I agree with the changes but now "gradle site:bootRun" doesn't work :( Apparently application.properties in site is required, while debugging I've seen that it gets correctly replaced later with the right one based on the environment passed as parameter.

So without application.properties in site the app must be launched like:

gradle site:bootRun -Dspring.profiles.active=dev
gradle site:bootRun -Dspring.profiles.active=prod

Otherwise it can't find properties in the site property files.

tylerbenson commented 9 years ago

odd... for some reason I didn't have that problem. try adding this

run {
    systemProperty "spring.profiles.active", "dev"
}

UnspeakableHorror commented 9 years ago

Nope. It's fine I'll just add the active profile manually.

I also tried adding the environment variable with "export spring.profiles.active=dev" but dots are no allowed on variables.

tylerbenson commented 9 years ago

You have to make it uppercase and replace the periods with underscores to use as an environment variable.

UnspeakableHorror commented 9 years ago

Yeah, sorry, I also tried that, didn't work :)

UnspeakableHorror commented 9 years ago

I think this can be merged now.

UnspeakableHorror commented 9 years ago

No, wait, I forgot to move the constant for env.

tylerbenson commented 9 years ago

@nelonoel @tarex could you check out this branch and try running the server the way you normally do just to make sure it starts ok?

UnspeakableHorror commented 9 years ago

You mean for spotless? Yes, sometimes I do that and sometimes I forget and just commit it later.