tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

Notify user that their contact information is kept private on Banner Edit #1098

Closed kalobkalob closed 9 years ago

kalobkalob commented 9 years ago

Seeing all profile info when looking at someone else's profile. Log into a resume, then look at a second resume. There should be some controls for how much info should be shown.

When working with your own profile: screenshot 2015-10-08 02 22 08

When working on someone else's profile: screenshot 2015-10-08 02 15 14

tylerbenson commented 9 years ago

I think this is to some degree intentional since we don't want to show private info to everyone. @nelonoel maybe there should be a notation to show which fields are private?

UnspeakableHorror commented 9 years ago

Yes, this is part of the private settings for account settings, since that feature is not available yet we can't change their privacy though.

nelonoel commented 9 years ago

This is intentional since we don't want to share contact details to everyone by default. Addressing this on new designs. Also, I remember front-end is submitting a privacy field on settings requests.

kalobkalob commented 9 years ago

I figured it was a privacy thing. It's a bad idea to surprise users like this. There are two ways to handle this, I kind of like facebook's way of handling things. Being able to mark if something is private, public, or only shared within a group. At the very least, some sort of notification about the info being hidden would be nice. For something like this website, people would expect everything to be visible unless told otherwise. I can think of several designs for this kind of thing if anyone wants to discuss this.

nelonoel commented 9 years ago

We're suppose to have this message on Banner Edit. But I guess you wanted more control over privacy of each field.

screen shot 2015-10-14 at 22 35 29
tylerbenson commented 9 years ago

If it's only the contact info on that side, perhaps put a box around them that matches that text color to tie it all together?

nelonoel commented 9 years ago

@tylerbenson would you like to just include the message while editing or implement the privacy toggle on each field?

tylerbenson commented 9 years ago

I think just while editing is ok...

kalobkalob commented 9 years ago

@nelonoel It's nicer to keep the layout clean. I think this is a case of where the notification doesn't need to show unless it's in edit mode.

nelonoel commented 9 years ago

Okay. Right. Will just show the message when editing.