Section position set on creation and update, merging of duplicate sections

tylerbenson / vyllage

https://www.vyllage.com

4 stars 0 forks source link

Section position set on creation and update, merging of duplicate sections #1103

Closed UnspeakableHorror closed 8 years ago

UnspeakableHorror commented 8 years ago

Fixes https://github.com/natebenson/vyllage/issues/1102. Fixes https://github.com/natebenson/vyllage/issues/1079. Fixes https://github.com/natebenson/vyllage/issues/1064.

Moved logic about setting a section position on creation or update.
Fixed bug where a section would be set as first on creation even though there was one already present.
Fixed duplicate positions on test script. (Sorry).
Added merging of duplicate sections for: Summary, Skills and Career Interests on creation and update.
Refactored addition of Contact data for Comments and Section Advice..

UnspeakableHorror commented 8 years ago

I'm going to include https://github.com/natebenson/vyllage/issues/1079 and https://github.com/natebenson/vyllage/issues/1064 here too.

UnspeakableHorror commented 8 years ago

The backend no longer allows changing the position of the Summary Section. The frontend should be changed to remove the ordering handle from the Summary Section.

UnspeakableHorror commented 8 years ago

For the existing duplicate sections once the user edits them they will be merged automatically but he will have to hit refresh to update the page or try to edit/create and save one, that will generate an error on the backend complaining that someone tried to edit a non existing section which is fine.

tylerbenson commented 8 years ago

Wow, good work. Didn't realize how involved this was going to be.

tylerbenson commented 8 years ago

Please create an issue for the front end to remove the move for summary.