search

tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

Editing avatar when the source is not Gravatar #1106

Open UnspeakableHorror opened 8 years ago

UnspeakableHorror commented 8 years ago

Currently, we support avatars from 3 different places, Gravatar (as fallback), Facebook and LTI. But on the resume header page it only allows setting up one of them, Gravatar.

Ideally, I think, the page should present the user the possibility of changing the source to any of the known avatars he has.

UnspeakableHorror commented 8 years ago

@nelonoel What do you think?

kalobkalob commented 8 years ago

I agree that there should be better controls for this, even using a direct url would be a nice quick solution. Right now the current setup doesn't work with secondary Gravatar emails.

tylerbenson commented 8 years ago

@kalobkalob could you give an example of that? I'm not familiar with different secondary email behavior.

nelonoel commented 8 years ago

What do you think of this guys?

screen shot 2015-10-14 at 22 59 19
tylerbenson commented 8 years ago

Perhaps display what we currently have stored for each photo? If no Facebook connection, offer to connect. If they're not connected via LTI or we don't already have an image from LTI then don't display that as an option. Also give guidance for how big the custom URL should be.

nelonoel commented 8 years ago

Good points! Source logos are not that helpful. Better display the actual photo from that source if it's already connected.

UnspeakableHorror commented 8 years ago

Currently the app returns the last set avatar, so displaying all of them will require some changes. Maybe an endpoint returning an array of urls? Or should it return the imgs themselves?

tylerbenson commented 8 years ago

Or you could add distinct settings for each avatar as well as a default avatar setting.

UnspeakableHorror commented 8 years ago

So we would have facebook-avatar, gravatar-avatar, selected-avatar (or default-avatar) and so on?

tylerbenson commented 8 years ago

I'm not saying the list idea was bad. Which option do you like better?

Probably want one for lti and custom.

@nelonoel maybe instead of saying LTI, we should just say School or School LMS.

nelonoel commented 8 years ago

@tylerbenson I'm okay with School LMS. @UnspeakableHorror aside from the list of avatars connected, maybe another field indicating which avatar is currently in use?

tylerbenson commented 8 years ago

Good idea, then let's just have a setting that references the right setting, rather than a default or selected avatar.