search

tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

Selection and copying problems #1135

Closed UnspeakableHorror closed 8 years ago

UnspeakableHorror commented 8 years ago

Allow selecting and ctrl+c the shared url link. Same for tables, I can't select the content of their cells . Share link button always stays greyed out and WAIT.. for me on Chromium, Firefox and Firefox Developer Edition.

nelonoel commented 8 years ago

Unselectable text is related to #1012 and can be solved by CSS. Copy to Clipboard problems on Firefox and Safari is caused by Flash dependency.

tylerbenson commented 8 years ago

I think having default be unslectable is too risky. Let's invert that. https://github.com/natebenson/vyllage/commit/cad52f60b4992ea15b9cb8722fdb52d2cfc77081#commitcomment-13972733

nelonoel commented 8 years ago

@tylerbenson you think so? We could just make table data cells selectable.

With elements unselectable by default, we don't have to make all the other elements (including the ones we'll be adding in the future) unselectable. Also, I was thinking it would be better to style only the elements that you intend to be selectable.

tylerbenson commented 8 years ago

I think that preventing election of things can be considered hostile, so I think we should err on theat side: unless we can be fairly confident we are allowing everything we should to be selectable, then we should probably change the default.

Disagree?

nelonoel commented 8 years ago

I would still prefer explicitly stating elements we intend to be selectable. On code, that would mean making form elements (textbox, textarea, etc) and recently, table data cells to be selectable. I would prefer that instead of retaining the default and making the headings, sections, specific divs.. (basically all the other elements) unselectable.

nelonoel commented 8 years ago

To illustrate, in the Resumé page alone, we have to disable selection of all the elements unnecessarily highlighted below:

screen shot 2015-10-26 at 23 13 07
tylerbenson commented 8 years ago

Ok, I'm fine with that if we can be sure to not cause unnecessary frustration.

nelonoel commented 8 years ago

Okay. I was assuming users would only intend to copy section and form element contents. Are there any other elements that they should be able to copy? Will add commits to #1146.

UnspeakableHorror commented 8 years ago

Everything that is data or links should be able to be selected :)