search

tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

section copy fixing #1146

Closed tarex closed 8 years ago

tarex commented 8 years ago

Closes #1135 Closes #1144

assigning @nelonoel for first review .

nelonoel commented 8 years ago

Code is all good! Will have to merge with #1136.

nelonoel commented 8 years ago

Just tested on other browsers.

Copies undefined on Safari.

screen shot 2015-10-26 at 18 11 38

Errors in Firefox.

screen shot 2015-10-26 at 18 13 49
nelonoel commented 8 years ago

Also, this doesn't fully close #1135 yet.

tarex commented 8 years ago

on safari it doesn't support direct clipboard copy without flash . but we can use window.selection then we need to modify the package .

tarex commented 8 years ago

@nelonoel added safari support with prompt . please review .

tylerbenson commented 8 years ago

@tarex tests are failing because of a missing dependency for zero clipboard. Please fix.

tarex commented 8 years ago

yes on it , fixing another related things with it .

nelonoel commented 8 years ago

Still doesn't work on Firefox. I'm not sure if I like the approach done in Safari. I thought we'll move away from flash-based library?

tarex commented 8 years ago

on my firefox its working , using latest version , yes haven't used flash based .

tarex commented 8 years ago

this library is purely js based : https://zenorocha.github.io/clipboard.js/ they used same approach form safari .

nelonoel commented 8 years ago

In progress: Selectable Elements