search

tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

Improved Zopim on Mobile: Fixes #1085 #1153

Closed nelonoel closed 8 years ago

nelonoel commented 8 years ago

Hid the bottom Chat button. Added a Support Button on the Mobile Menu

screen shot 2015-10-28 at 17 58 01
nelonoel commented 8 years ago

@UnspeakableHorror can you please check the test errors? They are all coming from junit. Odd because I didn't do any change on any Java file.

UnspeakableHorror commented 8 years ago

The errors are coming from thymeleaf, it can't find the templates. Also the failing tests are different on Solano and Circle 0.o

If, for whatever reason, gradle or npm fail on moving the templates to their proper location the tests will fail. I had this happen and similar every other build on Solano with "can't find assets/src directory" or whatever because npm/grunt/js-thing failed.

UnspeakableHorror commented 8 years ago

Still failing, I'll check locally.

UnspeakableHorror commented 8 years ago

Hmm, it runs fine locally too.

nelonoel commented 8 years ago

There are no npm errors as well. Hmm..

tylerbenson commented 8 years ago

Try merging from master again.

tylerbenson commented 8 years ago

Did @tarex get a chance to review this?

nelonoel commented 8 years ago

Oh. Not yet. I forgot that I moved the assignment to Carlos because of the CI errors.