search

tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

Try setting thymeleaf path. #1154

Closed UnspeakableHorror closed 8 years ago

UnspeakableHorror commented 8 years ago

Fixes https://github.com/natebenson/vyllage/issues/1155.

Fixes weird problem with CIs where the tests can't find the assets.

tylerbenson commented 8 years ago

This is the right way to add properties to tests: https://github.com/natebenson/vyllage/blob/master/build.gradle#L268

UnspeakableHorror commented 8 years ago

Ok.

UnspeakableHorror commented 8 years ago

It's ignoring gradle properties.

UnspeakableHorror commented 8 years ago

The second commit worked for accounts and connections but failed on site, so setting them on the test themselves works as a workaround.

tylerbenson commented 8 years ago

It wasn't ignoring it, the folder you gave it is an absolute file reference.

UnspeakableHorror commented 8 years ago

The path is correct now on the gradle script but it doesn't work.

Path: "/home/ubuntu/vyllage/assets/src/"

tylerbenson commented 8 years ago

Unfortunately this still doesn't explain why it doesn't see it on the classpath from the assets jar.

UnspeakableHorror commented 8 years ago

Well, no, but he only reasonable explanation is that something was updated on the CIs servers that caused both of them to start failing. Unless someone edited something without merging it via PR there's no other explanation (I think), since the last change is from two days ago and was working fine then some update is the most likely cause of the problem.

Unfortunately I do not have an Ubuntu machine to test this.

By the way, I don't have the system property set, so it's not because of that that it works locally either.