search

tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

New Landing Pages #1192

Closed nelonoel closed 8 years ago

tylerbenson commented 8 years ago

@nelonoel do you still want a login page at /login? Perhaps logout should go to the home page?

tylerbenson commented 8 years ago

Two suggestions. I think some quick transitions between the states when clicking on login/register and then the button to show the form (setup profile/email) would help provide context for the user.

Also maybe not so dark on the overlay to help the user know they're still on the same page, and a close button in the corner to ensure they realize that it's closable?

tylerbenson commented 8 years ago

@tarex do you want to take a look at this? I'm mainly just looking at it visually: https://vyllage-pr-1192.herokuapp.com but you may have insight on the underlying code.

tarex commented 8 years ago

checking

tarex commented 8 years ago

its OK , merge it .

tylerbenson commented 8 years ago

@natebenson any comments on this?

natebenson commented 8 years ago

looks good!