search

tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

Detect graduation date #1194

Closed UnspeakableHorror closed 8 years ago

UnspeakableHorror commented 8 years ago

Closes https://github.com/natebenson/vyllage/issues/1170.

Added endpoint to determine if a user has graduated checking his education sections. Added check using the new endpoint at CurrentStudentContactSelector.

tylerbenson commented 8 years ago

Seeing as we want to allow them to override it if it's incorrect, do you think storing it in a setting would be a good option?

@nelonoel does this look like a reasonable API?

UnspeakableHorror commented 8 years ago

It's already in the account settings, that's used to override. This is not intended to be used by the frontend but the suggestion service.

nelonoel commented 8 years ago

It's already in the account settings. Not sure if that is currently pre-filled though. Maybe we could add a "Add Graduation Date" task to the User Onboarding Guide?

UnspeakableHorror commented 8 years ago

It's not prefilled, that field overrides whatever you have on your resume.