search

tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

fixed tag problem #1210

Open tarex opened 9 years ago

tarex commented 9 years ago

Closes #1181

UnspeakableHorror commented 9 years ago

@tarex the build is failing with:

[00:20:01] Starting 'shrinkwrap'...
Unhandled rejection Error: Problems were encountered
Please correct and try again.
missing: react-autosuggest@^1.9.0, required by project-assets@0.0.0
    at shrinkwrap_ (/home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/lib/shrinkwrap.js:31:15)
    at /home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/lib/shrinkwrap.js:25:5
    at /home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/lib/ls.js:47:30
    at /home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/node_modules/read-installed/read-installed.js:138:5
    at /home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/node_modules/read-installed/read-installed.js:251:14
    at cb (/home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/node_modules/slide/lib/async-map.js:47:24)
    at /home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/node_modules/read-installed/read-installed.js:251:14
    at cb (/home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/node_modules/slide/lib/async-map.js:47:24)
    at /home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/node_modules/read-installed/read-installed.js:251:14
    at cb (/home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/node_modules/slide/lib/async-map.js:47:24)
    at /home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/node_modules/read-installed/read-installed.js:251:14
    at cb (/home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/node_modules/slide/lib/async-map.js:47:24)
    at /home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/node_modules/read-installed/read-installed.js:251:14
    at cb (/home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/node_modules/slide/lib/async-map.js:47:24)
    at /home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/node_modules/read-installed/read-installed.js:251:14
at cb (/home/ubuntu/vyllage/assets/node_modules/gulp-shrinkwrap/node_modules/npm/node_modules/slide/lib/async-map.js:47:24)
tarex commented 9 years ago

it should fixed now .

nelonoel commented 9 years ago

Still doesn't close #1182.

Instead, the user has to press Enter again after clicking the autocomplete suggestion.

screen shot 2015-12-04 at 22 56 15 1
tarex commented 9 years ago

removed #1182 @nelonoel check now

nelonoel commented 9 years ago

@tarex please check why npm test fails.

UnspeakableHorror commented 9 years ago

The tests are failing, for some reason it's sending 'user' instead of the userId in one of the tests, or at least that's what looks like to me.

Edit: Actually, it seems the userId is missing in the test url, it should be

"/document/user/{userId}/document-type/RESUME"

INFO [karma]: Karma v0.12.37 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
INFO [PhantomJS 1.9.8 (Linux 0.0.0)]: Connected on socket F1Z33qMw04unve0xd7nn with id 68314928
PhantomJS 1.9.8 (Linux 0.0.0) ERROR
  SyntaxError: Parse error
  at /home/ubuntu/vyllage/assets/src/components/resume/test/editor.test.jsx:60692

WARN [web-server]: 404: /document/user/document-type/RESUME
WARN [web-server]: 404: /document/user/document-type/RESUME
npm ERR! Test failed.  See above for more details.
npm ERR! Test failed.  See above for more details.
tarex commented 9 years ago

i'm not sure why its failing , haven't found anything that related to it in editor test .

nelonoel commented 9 years ago

This often happens to me before. I tried commenting out editor.test.jsx and it showed an error at tags.test.jsx. Editor is the parent component so it stops parsing when a blocking error occurs in there so you really have to dig deeper. Kindly check the tags component. :)