search

tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

bullet point is not saving :( #1212

Closed natebenson closed 8 years ago

natebenson commented 8 years ago

enter information into the bullet point and click save, and it disappears. Also, the add button is not showing up to add multiple bullet points.

nelonoel commented 8 years ago

This is an error on the resume action.js file. In fact, it's not just the highlights affected but the editing of sections in general. Fixed in #1214

tylerbenson commented 8 years ago

The most concerning part of this is that it might silently discard user input. If there's an error saving content, the user should know about it so no work is lost.

nelonoel commented 8 years ago

Right. That would definitely suck on the part of the user. However, this is not caused by an async error (throwing exceptions) which can then be handled in the front-end. It was a silly syntax error.

nelonoel commented 8 years ago

It should be covered by unit tests.

tylerbenson commented 8 years ago

I think that shouldn't matter. Can't we have some better error handling for either case?

nelonoel commented 8 years ago

Syntax errors should be caught by unit / integration tests. It's something that can't be handled programmatically in Javascript (being a scripting language). However, async errors can be handled in the front-end to inform the user that their changes were not saved.