tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

Remind user to update resumé #955

Open nelonoel opened 9 years ago

nelonoel commented 9 years ago
screen shot 2015-09-07 at 19 12 39

Clarification: @natebenson @tylerbenson When should we consider a resumé outdated?

natebenson commented 9 years ago

I think having a 30 day mark would be good. It isn't super imposing, but a subtle reminder, so I don't think having it appear more often is a problem. In fact, I think the text needs to be a little more legible. It is too small in my opinion, and should be a little more prominent.

nelonoel commented 9 years ago

Okay. Planning to revise the design of this one as well. :)

tylerbenson commented 9 years ago

This trigger should also be tied into our notification stream.

UnspeakableHorror commented 8 years ago

I think it should be one or the other, not both. If it needs to be added to the notifications in https://github.com/natebenson/vyllage/pull/1152 then it will require changes in the backend, to check when the user access the document how long has it been since he changed it.

For the current design there's an endpoint that returns the last modification date. GET /document/user/{userId}/modified-date

UnspeakableHorror commented 8 years ago

For clarification, I don't want the frontend creating notifications nor having to manipulate too much the notifications themselves. Notifications should only be created on the backend as a result of some process.

tylerbenson commented 8 years ago

That's a valid argument. For now, this issue can be to just deal with the banner. The notification can be done later.

nelonoel commented 8 years ago

Okay. Will use the endpoint for last modification date instead. What about adding this to the Milestones Panel instead of the Notifications?

tylerbenson commented 8 years ago

If the user hasn't been to the site in a long time, that wouldn't trigger a reminder email, would It?

UnspeakableHorror commented 8 years ago

What Milestone panel?

nelonoel commented 8 years ago

@UnspeakableHorror this: screen shot 2015-11-17 at 10 35 00

UnspeakableHorror commented 8 years ago

Ah, ok, I forgot about that one.