Open nelonoel opened 9 years ago
I think having a 30 day mark would be good. It isn't super imposing, but a subtle reminder, so I don't think having it appear more often is a problem. In fact, I think the text needs to be a little more legible. It is too small in my opinion, and should be a little more prominent.
Okay. Planning to revise the design of this one as well. :)
This trigger should also be tied into our notification stream.
I think it should be one or the other, not both. If it needs to be added to the notifications in https://github.com/natebenson/vyllage/pull/1152 then it will require changes in the backend, to check when the user access the document how long has it been since he changed it.
For the current design there's an endpoint that returns the last modification date. GET /document/user/{userId}/modified-date
For clarification, I don't want the frontend creating notifications nor having to manipulate too much the notifications themselves. Notifications should only be created on the backend as a result of some process.
That's a valid argument. For now, this issue can be to just deal with the banner. The notification can be done later.
Okay. Will use the endpoint for last modification date instead. What about adding this to the Milestones Panel instead of the Notifications?
If the user hasn't been to the site in a long time, that wouldn't trigger a reminder email, would It?
What Milestone panel?
@UnspeakableHorror this:
Ah, ok, I forgot about that one.
Clarification: @natebenson @tylerbenson When should we consider a resumé outdated?