search

tylerbrawl / Galaxy-Plugin-Rockstar

MIT License
71 stars 7 forks source link

rockstar plugin stuck #48

Open FregrinZ opened 5 years ago

FregrinZ commented 5 years ago

Hello,

The following plugins seem stuck psn,origin and rockstar. They are forever connecting and also do not display all my games ?

I looked in C:\Users\name\AppData\Local\GOG.com\Galaxy\plugins\installed and deleted plugins,but each time i launch gog they just come back again.

I also tried end task on python under details task manager..

How do i fix this issue please ?

tylerbrawl commented 5 years ago

Could you post your plugin log file? You can find it at C:\ProgramData\GOG.com\Galaxy\logs\plugin-rockstar-774732b5-69c4-405c-b6c9-92cd55740cfe.log. If you cannot find C:\ProgramData, then make sure to enable the ability to view hidden files and folders. Instructions to do so can be found here: https://support.microsoft.com/en-ae/help/4028316/windows-view-hidden-files-and-folders-in-windows-10.

FriendsOfGalaxy commented 5 years ago

This is similar to bug in Galaxy that we've found few days ago. Infinite spinner during authenticate occurs when plugin throws not expected Exception. I'm sure that InvalidCredentials is ok, but don't know what else is "expected" by Galaxy.

Infinite spinner in origin was because of KeyError aised from API code during authentication. We have workaround this yesterday in https://github.com/FriendsOfGalaxy/galaxy-integration-origin/commit/877c5e476943c4b235c671d71266ae7b78eadf1e

FriendsOfGalaxy commented 5 years ago

3.5 on windows is ok, but on macos, during authentication with open(os.path.join(__file__, '..', 'js', file), 'r') as f:

throws: NotADirectoryError [Errno 20]

wrap frist open argument in os.path.abspath like this:

with open(os.path.abspath(os.path.join(__file__, '..', 'js', file), 'r'))

or use pathlib:

import pathlib
with open(pathlib.Path(__file__).parent / 'js' / file) as f:

Sorry for introducing this bug, as it was my proposal last time.

BTW: there is fix for first problem in galaxy.api==0.59 https://github.com/gogcom/galaxy-integrations-python-api/releases

tylerbrawl commented 5 years ago

I implemented this fix in the fog_release branch and set galaxy.plugin.api==0.59 in the requirements.txt file.

@FregrinZ - Could you test the attached build? It incorporates these fixes and may solve your problem.

plugin.zip