tylerbrawl / Galaxy-Plugin-Rockstar

MIT License
71 stars 7 forks source link

Plugins Frequently Disconnecting #59

Closed olegbl closed 4 years ago

olegbl commented 4 years ago

Half the time I start up GOG, the Rockstar plugin is disconnected and I have to re-connect it by entering username/password again.

Attached: Plugin logs (inside a zip 'cause GitHub doesn't like txt)

Looks like a bunch of 400 Bad Requests during auth.

Edit: forgot to mention:

tylerbrawl commented 4 years ago

It seems like the plugin is failing to refresh credentials during authentication. This might be caused by a failure to update required cookies, but I am not certain from looking at the provided log file alone.

Could you try downloading and installing the v0.4-Pre3 plugin version? It drastically changes authentication flow (again), but I have not had a single disconnect since. This version makes sure to update all cookies in the session object that were set in a response. In addition, it appears to actually be very stable; I am just waiting to be able to test various social features before I send it to the fog_release branch for publishing. ~(@FriendsOfGalaxy, does the user presence feature work in Galaxy 2.0 right now, or has it only been added to the API for later use?)~ EDIT: I just got the latest update for Galaxy 2.0. As it is in v0.4-Pre3, attempting to get user presence with the plugin is throwing numerous exceptions. I am currently working on fixing these.

(Side Note: I know that the first version number for the Rockstar Games Launcher (1.0.16.196.1) is the version of the launcher client itself, and the purpose of the build number should be fairly obvious. The second version number (2.0.4.3) likely refers to their API version, as some of the Social Club source code references a v2 of an API which I presume belongs to games only (i.e., GTA V, RDR 2, and L.A. Noire).)

olegbl commented 4 years ago

Could you try downloading and installing the v0.4-Pre3 plugin version?

Will do! Thanks!

The second version number (2.0.4.3) likely refers to their API version

Interesting!

EDIT:

Killed GOG. Updated plugin to 0.4pr3. Restarted GOG. Rockstar disconnected. Connected Rockstar. Killed GOG. Restarted GOG. Rockstar stayed connected. Seems to be working fine atm. Will comment back after a few days / if it starts disconnecting again.

olegbl commented 4 years ago

0.4pre3 has been working solid last few days! Thanks!

tylerbrawl commented 4 years ago

I'm glad to hear it! I have been waiting for user presence to work correctly before releasing v0.4 as a final release (see #60 for details).