search

tylerbutler / xkcd2

http://www.tylerbutler.com/2012/05/17/xkcd-2/
MIT License
14 stars 4 forks source link

Bottom bar takes too much space on mobile #2

Closed tylerbutler closed 9 years ago

tylerbutler commented 10 years ago

Screenshot from iPhone:

2014-05-12 17 54 06

From Windows Phone:

wp_ss_20140512_0003

whitecat commented 10 years ago

A few options I have thought up. 1) Make text smaller on bottom bar, 2) Fix bottom bar in position at the bottom of page 3) make bottom bar a non dynamic size 4) make bottom bar collapsable.

tylerbutler commented 10 years ago

Thanks! I'm leaning towards either 1 or 2 on mobile only. Just need the time to actually do it!

whitecat commented 10 years ago

I can give it a try and push a change. Lets see if I get time this week. I love looking at the site on my phone it is so much more beautiful than xkcd.

tylerbutler commented 10 years ago

Thanks! The site currently uses the (now ancient) Foundation 2.2.1 CSS lib, and the mobile visibility classes might be useful in this case.

whitecat commented 10 years ago

I checked documentation. The 2 solutions: 1) Upgrade to Foundation 5. 2) When a mobile use "show-on-phones" and create a navbar outside of Foundation and hide the current header and footer and implement

Which do you prefer?

tylerbutler commented 10 years ago

Option 2 makes sense. I'm not sure about option 1. Are you saying that upgrading to foundation 5 would magically solve the problem, or does it just make some better options available to address the problem? Either way, I'm fine with either approach. If you send a pull request I can definitely take a look. Thanks!

whitecat commented 10 years ago

Let me know what you think. http://c.albert-thompson.com/xkcd/test2.html

None of the buttons work. Just the css if that is ok.

whitecat commented 9 years ago

Are there any issues? My pull should work right out of the box. I changed foundations to bootstrap.