search

tylerchilds / cutestrap

A strong, independent CSS Framework. Only 2.7KB minified & gzipped.
https://www.cutestrap.com
GNU General Public License v3.0
1.57k stars 79 forks source link

Should tag names be included in style definitions? #35

Closed ericyd closed 5 years ago

ericyd commented 8 years ago

I really like the minimalism of Cutestrap, but I have found myself fighting with the button styling when trying to use semantic markup in my nav elements. I was recently reading through BEM naming conventions and noticed that it specifies "No tag name or ids" for CSS selectors. Conversely, Cutestrap docs state that "A default button is applied with the .btn class or automatically on button tags or button/submit inputs."

Is this implementation of tag styling in Cutestrap intentional? Am I referencing incorrect documentation for BEM?

tylerchilds commented 8 years ago

Good point. I think this might be a conflict of interest between providing a default button style and and BEM. I took a lot of liberty with styling many tags, like blockquote. Buttons are more of a gray area, is it a standard UI element or is it a BEM block? I think it's a little bit of both, which is why I chose .btn and for <button>.

I think it would be a good idea to drop the as opinionated state of the default tags, similar to how the other default form elements require classes to operate fully.

tylerchilds commented 5 years ago

2.0 less opionated on default buttons and leans on using .button class