search

tylergaw / day-player

A Sketch Plugin for creating placeholder images from online services.
MIT License
391 stars 22 forks source link

Add placepuppy.it service to Day Player #10

Closed johnflynn closed 10 years ago

johnflynn commented 10 years ago

This is basically the first thing we did when introducing Sketch to the DogVacay team, so I thought I'd add it to the master plugin. Thanks for your work, this is super helpful!

Notes: placepuppy.it's docs say they support text, but the service seems to be broken, so it's left out of the plugin.

tylergaw commented 10 years ago

Excellent, thanks @bryne. I have your branch pulled down, code is all lookin' good. And thank you for spotting that typo. I've overlooked that so many time. Place Puppy has been down today so I haven't been able to test it in Sketch. When it's back up I'll kick it around a bit and then get this merged in.

The site being down revealed something that needs fixed though, not in your PR, just in general. Put an issue in for myself https://github.com/tylergaw/day-player/issues/11

johnflynn commented 10 years ago

Yeah, I see the service is a little slow to respond now—I emailed the author who's looking into it.

Not currently a great candidate for a merge. Great example for error handling, though!

tylergaw commented 10 years ago

@bryne Finally getting this merged in. In my testing today the service seems to be working well.

I am seeing a bit of weirdness that I can't figure out, but it feels OK. I notice that sometimes it gives back an image that is a different size than was requested. Seems to happen most often on odd sizes. Sometimes a request for a size like 406/204px will give back a 203/102px image. But not always.

Went ahead and put it in because I feel like it works correctly often enough. Thanks :+1:

labmouse commented 10 years ago

Hey , I'm not the person that you meant to add to this project.

On Sat, Nov 1, 2014, 12:54 PM Tyler Gaw notifications@github.com wrote:

@bryne https://github.com/bryne Finally getting this merged in. In my testing today the service seems to be working well.

I am seeing a bit of weirdness that I can't figure out, but it feels OK. I notice that sometimes it gives back an image that is a different size than was requested. Seems to happen most often on odd sizes. Sometimes a request for a size like 406/204px will give back a 203/102px image. But not always.

Went ahead and put it in because I feel like it works correctly often enough. Thanks [image: :+1:]

— Reply to this email directly or view it on GitHub https://github.com/tylergaw/day-player/pull/10#issuecomment-61374650.