tylerguy / color-utils

Provides functions for color manipulation

MIT License

0 stars 0 forks source link

Colors not accurate when converting colors from hsl > rgb when calling triadic and tetradic functions #1

Open tylerguy opened 8 months ago

tylerguy commented 8 months ago

When converting from a HSL to RGB color whenever getTriadicColor and getTetradicColor are called, rgb values end up being either 1 higher or lower.

tylerguy commented 8 months ago

Few test cases to check

ec0ffd - should return `[ 253, 236, 15 ], [ 15, 253, 236 ]`, but returns `[ 253, 237, 15 ], [ 15, 253, 237 ]`

ec0ffe - should return `[ 254, 236, 15 ], [ 15, 254, 236 ]` but returns `[ 254, 234, 15 ], [ 15, 254, 234 ]` (this is more of a difference than previously observed)

tylerguy / color-utils

Colors not accurate when converting colors from hsl > rgb when calling triadic and tetradic functions #1

ec0ffd - should return [ 253, 236, 15 ], [ 15, 253, 236 ], but returns [ 253, 237, 15 ], [ 15, 253, 237 ]

ec0ffe - should return [ 254, 236, 15 ], [ 15, 254, 236 ] but returns [ 254, 234, 15 ], [ 15, 254, 234 ] (this is more of a difference than previously observed)

ec0ffd - should return `[ 253, 236, 15 ], [ 15, 253, 236 ]`, but returns `[ 253, 237, 15 ], [ 15, 253, 237 ]`

ec0ffe - should return `[ 254, 236, 15 ], [ 15, 254, 236 ]` but returns `[ 254, 234, 15 ], [ 15, 254, 234 ]` (this is more of a difference than previously observed)