feat(*): upgrade all 3rd party dependencies and move to modern bundle and tooling

tylerhubert / rsql-criteria-typescript

RSQL Criteria Builder for Typescript

MIT License

13 stars 5 forks source link

feat(*): upgrade all 3rd party dependencies and move to modern bundle and tooling #15

Closed justinrassier closed 3 years ago

justinrassier commented 3 years ago

Modernizing the repo

Motivation:

The current build creates and es5 build. Modern tooling can't take advantage of tree-shaking and other optimizations.

Also, it just feels good to be up to date :)

Overview of changes

update all dependencies to the latest versions
Move to eslint instead of TSLint - this came from being unable to resolve TSLint errors after upgrade.
Ran eslint --fix on the project to fix auto-fixable issues
added some eslint-ignore statements for warnings as to not change any source
Changed the output of the build to es2015
Added a tsconfig.es5.json file for rollup to still create legacy bundles
Tested agains an Angular 11 project with tests still passing

tylerhubert commented 3 years ago

Hey Justin, it appears that the libs are pulling from IC's Artifactory instead of NPM. Can you please rectify that? You can see the build here: https://travis-ci.org/github/tylerhubert/rsql-criteria-typescript/jobs/749066102

Not sure why the build didn't auto link into here. It used to do that.

justinrassier commented 3 years ago

@tylerhubert ugh, I totally should have thought of that. I will make a note to fix that up. Sorry!

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 48

23 of 23 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 46:	0.0%
Covered Lines:	255
Relevant Lines:	255

💛 - Coveralls

justinrassier commented 3 years ago

@tylerhubert all updated and CI passing. Let me know if you need me to do anything else.

tylerhubert commented 3 years ago

This all looks good to me. Support for this repository is supposed to be moved over to the IC repo version of it here: https://github.com/infinitecampus/rsql-criteria-typescript

However, I don't think the automated build/publish out to NPM is setup in the IC version of this yet. So we can merge this here to create/publish the NPM artifact and then cherry pick the commit over to the IC repo.

tylerhubert commented 3 years ago

:tada: This PR is included in version 2.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: