search

tylerjchuba / soar-behaviors

BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Successful playbooks with failed actions throw PlaybookException #3

Open bramcod2 opened 7 months ago

bramcod2 commented 7 months ago

During the step When the playbook "repo/playbook" is ran, if an action fails, then a PlaybookException is raised, even though the playbook runs successfully and finishes as a success.

This means I can't validate the actions that I am really interested in during my Then statements or verify that certain actions fail and how that affects the rest of the playbook.

I would expect the When the playbook "repo/playbook" is ran step to run the playbook and only raise an error if there was an issue actually running the playbook, or if the playbook failed due to daemon restart or something else system related, but not error out if the playbook failed for a different reason like code error or action failure. I'd expect users to include checks that the playbook finished successfully or failed during their "Then" checks.

bramcod2 commented 7 months ago

Even when using the @ignore_exception tag is used an issue persists, but it looks like that is an issue on line 51 of interaction_steps.py. There is no "Exceptions" in soarsdk, but there is an "exceptions".