search

tylerlong / google-code-prettify

Automatically exported from code.google.com/p/google-code-prettify
Apache License 2.0
0 stars 0 forks source link

More verbose CSS class names #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I think the current CSS class names are not verbose enough, you can't
understand their purpose by just reading the CSS file.

Why not just change them to:
.str -> .string
.kwd -> .keyword
etc...

Original issue reported on code.google.com by kamil.ki...@gmail.com on 29 Mar 2007 at 5:36

GoogleCodeExporter commented 9 years ago 
I think you're right that I should've used longer names, but those names are
preexisting and so effectively part of the API so changing them would break 
backwards
compatibility.

Wheen you saw those class names, where did you first look for documentation?

Original comment by mikesamuel@gmail.com on 29 Mar 2007 at 6:25

GoogleCodeExporter commented 9 years ago 
Well, I was able to figure out what they were by looking at the style name 
tokens in
the Javascript file, but I don't think this is a good way to do it. I would 
suggest
that since your project is still in its relative infancy this is a good time to 
make
the change in CSS and get it right once and for all. Yes, you could write some
documentation to cover it but that will always add an extra step for designers. 
Some
of the tags are very non-obvious such as .dec, .atv, .atc, and .pln in 
particular.

Original comment by kamil.ki...@gmail.com on 3 Apr 2007 at 9:16

GoogleCodeExporter commented 9 years ago 
fair enough, but I do have to deal with an installed base within the company I 
work for.

Original comment by mikesamuel@gmail.com on 18 May 2007 at 9:42

GoogleCodeExporter commented 9 years ago 
Since Prettify marks up the HTML on the fly, the CSS class names probably 
should not 
be used anywhere else in the HTML. So, why does the installed base care that 
the 
class names are? The installed base would only need to update any existing CSS 
with 
the "old" class names.

Original comment by tbuch...@gmail.com on 4 Aug 2007 at 1:13

GoogleCodeExporter commented 9 years ago 
Users can tweak the CSS file to get styling closer to what they see in their 
favorite
source editor, so changing the names would require updating all those CSS files.

Original comment by mikesamuel@gmail.com on 4 Aug 2007 at 9:19

GoogleCodeExporter commented 9 years ago

Original comment by mikesamuel@gmail.com on 23 Oct 2007 at 1:22