search

tylermercer / conversation-prompt-generator

A web app that provides the user with conversation prompts that are designed to promote meaningful conversation.
https://cpg.tylermercer.net
1 stars 1 forks source link

Added 14 new prompts #4

Closed lucaskenji closed 4 years ago

lucaskenji commented 4 years ago

Related to issue #2 Modified prompts.ts in order to add 14 more conversation prompts

lucaskenji commented 4 years ago

Hello, sorry if it's a stupid question but I don't understand what you mean by sorting the new ones into the list. (Also, how about letting the user suggest some prompts to add?)

tylermercer commented 4 years ago

So right now, the ones higher in the list don't require a lot of personal vulnerability to discuss. For example, "What would the perfect day look like for you?" is something you could talk about with basically anyone, whereas "The death of which of your family members would impact you the most" is a much deeper question and requires more vulnerability.

I'd like to maintain that ordering as new prompts are added. That was what I meant by sorting them in.

I'll make a commit to this branch that shows what I mean.

On Tue, Mar 24, 2020, 9:51 AM lucaskenji notifications@github.com wrote:

Hello, sorry if it's a stupid question but I don't understand what you mean by sorting the new ones into the list. (Also, how about letting the user suggest some prompts to add?)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tylermercer/conversation-prompt-generator/pull/4#issuecomment-603322393, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXCPR2LLD26LQSWO4WC7RTRJDJIDANCNFSM4LSL4QWQ .

tylermercer commented 4 years ago

Hello, sorry if it's a stupid question but I don't understand what you mean by sorting the new ones into the list. (Also, how about letting the user suggest some prompts to add?)

Re: user-suggested prompts: I just added this as issue #6.

lucaskenji commented 4 years ago

So right now, the ones higher in the list don't require a lot of personal vulnerability to discuss. For example, "What would the perfect day look like for you?" is something you could talk about with basically anyone, whereas "The death of which of your family members would impact you the most" is a much deeper question and requires more vulnerability. I'd like to maintain that ordering as new prompts are added. That was what I meant by sorting them in. I'll make a commit to this branch that shows what I mean.

I guess I skipped the text that explained that on the app, now I understand. Should I make another commit or does your commit solve that problem?

tylermercer commented 4 years ago

So right now, the ones higher in the list don't require a lot of personal vulnerability to discuss. For example, "What would the perfect day look like for you?" is something you could talk about with basically anyone, whereas "The death of which of your family members would impact you the most" is a much deeper question and requires more vulnerability. I'd like to maintain that ordering as new prompts are added. That was what I meant by sorting them in. I'll make a commit to this branch that shows what I mean.

I guess I skipped the text that explained that on the app, now I understand. Should I make another commit or does your commit solve that problem?

That solves it! I'll go ahead and merge. Thanks for contributing!