tylermilner / cookiecutter-ios-swiftui

Cookiecutter template for jump-starting modern iOS apps using SwiftUI.
MIT License
1 stars 0 forks source link

Fix output repo deployment if previous build fails #26

Closed tylermilner closed 5 months ago

tylermilner commented 6 months ago

It looks like there is a bug in the GHA workflow where changes aren't being detected properly if the test job fails.

#47 failed:

#48 succeeded:

It seems like the deployment job needs to check for changes against the last time the deployment job was run vs just checking for changes in the recently pushed commit(s). We may need to abandon the dorny/paths-filter action in favor of some different logic.

tylermilner commented 5 months ago

This has been fixed now that the tests and deployment are done in separate workflows, along with using tylermilner/last-successful-commit-hash-action to determine the last successful run of the deployment workflow.

Tested the fix between bd66479912d782505c62fc9717513b8726cb2995 (Deploy #17) and 6180c46aaf4cf988fdfb13422a84d29e2eb8b8eb (Deploy #19, where test failure occurred along with test template file changes:

image