Closed tylermilner closed 5 months ago
This has been fixed now that the tests and deployment are done in separate workflows, along with using tylermilner/last-successful-commit-hash-action to determine the last successful run of the deployment workflow.
Tested the fix between bd66479912d782505c62fc9717513b8726cb2995 (Deploy #17) and 6180c46aaf4cf988fdfb13422a84d29e2eb8b8eb (Deploy #19, where test failure occurred along with test template file changes:
It looks like there is a bug in the GHA workflow where changes aren't being detected properly if the
test
job fails.#47 failed:
{{ cookiecutter.project_root }}/run-tests.sh
, forgetting to updatetest_template.py
which caused the failure. If the tests had succeeded, detecting a change to this file would have triggered a deployment to the output repo.#48 succeeded:
{{ cookiecutter.project_root }}
directory in this commit so thedeploy
job wasn't triggered.It seems like the deployment job needs to check for changes against the last time the deployment job was run vs just checking for changes in the recently pushed commit(s). We may need to abandon the
dorny/paths-filter
action in favor of some different logic.