tylermilner / cookiecutter-ios-swiftui

Cookiecutter template for jump-starting modern iOS apps using SwiftUI.
MIT License
1 stars 0 forks source link

Investigate "Deploy" badge failures #32

Closed tylermilner closed 3 months ago

tylermilner commented 5 months ago

It looks like the "Deploy" badge in the README might be red due to the workflow being skipped when no changes are detected. We need to see if we can consider "skipped" as "passed" or just make the workflow pass if no deployment needs to happen (as it recently was).

tylermilner commented 3 months ago

It looks like being able to treat manually cancelled workflow runs as non-failures is a requested feature, but hasn't been implemented yet:

As a workaround, I removed the step that cancelled the workflow run using the GitHub CLI if no changes were detected.

Now the status badge shows as "Passing":

image

The workflow run also shows as passing now:

image

Clicking into the run shows that the deployment job was actually skipped:

image

The above behavior is in contrast to when the workflow run was manually cancelled, which showed the run as being skipped/cancelled:

image image
tylermilner commented 3 months ago

Fixed in e1835ed56fd2748dc885524668bc40551ad227e2.