tylermorganwall / rayrender

A pathtracer for R. Build and render complex scenes and 3D data visualizations directly from R
http://www.rayrender.net
622 stars 42 forks source link

Define STRICT_R_HEADERS, include cfloat in two headers #25

Closed eddelbuettel closed 3 years ago

eddelbuettel commented 3 years ago

Dear Tyler,

Your CRAN package rayrender uses Rcpp, and is affected if we add a definition of STRICT_R_HEADERS as we would like to do. Please see the discussion at https://github.com/RcppCore/Rcpp/issues/1158 and the links therein for more context on this.

Here we just define STRICT_R_HEADERS in Makevars and include cfloat (or float.h, C style) in two files (as one of your headers "gets around" to most C++ files) so that DBL_MIN is defined. No other changes were made.

It would be lovely if you could apply this. There is no strong urgency: we aim to get this done over all affected packages in the space of a few months. If you apply it, would you mind dropping me a note by email or swinging by https://github.com/RcppCore/Rcpp/issues/1158 to confirm?

Many thanks for your help, and I hope you continue to find Rcpp helpful. Please don't hesitate to ask if you have any questions.

eddelbuettel commented 3 years ago

Thanks!