tylermorganwall / skpr

Generates and evaluates D, I, A, Alias, E, T, G, and custom optimal designs. Supports generation and evaluation of mixture and split/split-split/N-split plot designs. Includes parametric and Monte Carlo power evaluation functions. Provides a framework to evaluate power using functions provided in other packages or written by the user.
https://tylermorganwall.github.io/skpr/
GNU General Public License v3.0
115 stars 15 forks source link

BUG: 'length(x) = 2 > 1' in coercion to 'logical(1)' - R CMD check++ #50

Closed HenrikBengtsson closed 4 years ago

HenrikBengtsson commented 5 years ago

Adding the following to ~/.Renviron:

## Supported since R (>= 3.4.0)
_R_CHECK_LENGTH_1_CONDITION_=true

## Supported since R (>= 3.6.0)
_R_CHECK_LENGTH_1_LOGIC2_=true

produces the following R CMD check --as-cran error:

* using log directory ‘/home/hb/repositories/future/revdep/checks/skpr/old/skpr.Rcheck’
* using R version 3.6.0 (2019-04-26)
* using platform: x86_64-pc-linux-gnu (64-bit)
* using session charset: UTF-8
* using options ‘--no-manual --no-build-vignettes’
* checking for file ‘skpr/DESCRIPTION’ ... OK
* this is package ‘skpr’ version ‘0.57.0’
* package encoding: UTF-8
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for executable files ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking for sufficient/correct file permissions ... OK
* checking whether package ‘skpr’ can be installed ... NOTE
Found the following notes/warnings:
  Non-staged installation was used
See ‘/home/hb/repositories/future/revdep/checks/skpr/old/skpr.Rcheck/00install.out’ for details.
* checking installed package size ... NOTE
  installed size is 49.1Mb
  sub-directories of 1Mb or more:
    libs  47.6Mb
* checking package directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* checking whether the package can be loaded ... OK
* checking whether the package can be loaded with stated dependencies ... OK
* checking whether the package can be unloaded cleanly ... OK
* checking whether the namespace can be loaded with stated dependencies ... OK
* checking whether the namespace can be unloaded cleanly ... OK
* checking loading without being on the library search path ... OK
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking line endings in C/C++/Fortran sources/headers ... OK
* checking line endings in Makefiles ... OK
* checking compilation flags in Makevars ... OK
* checking for GNU extensions in Makefiles ... OK
* checking for portable use of $(BLAS_LIBS) and $(LAPACK_LIBS) ... OK
* checking compiled code ... OK
* checking examples ... OK
* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ... ERROR
  Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  'length(x) = 2 > 1' in coercion to 'logical(1)'
  1: expect_equal(coef(summary(fitglm))[, 4], extractPvalues(fitglm)) at testthat/testExtractPvalues
.R:14
  2: quasi_label(enquo(expected), expected.label, arg = "expected")
  3: eval_bare(get_expr(quo), get_env(quo))
  4: extractPvalues(fitglm)

  ══ testthat results  ═══════════════════════════════════════════════════════════
  OK: 339 SKIPPED: 1 WARNINGS: 0 FAILED: 4
  1. Error: eval_design_mc processes effectsize properly for glm (@testDeltaProcessing.R#132) 
  2. Error: eval_design_mc processes effectsize properly for glm without effect power (@testDeltaPro
cessing.R#184) 
  3. Error: eval_design_mc example code runs without errors (@testExampleCode.R#289) 
  4. Error: extractPvalues works as intended (@testExtractPvalues.R#14) 

  Error: testthat unit tests failed
  Execution halted
* DONE
Status: 1 ERROR, 2 NOTEs

Can be upstreams - I havn't investigated.

tylermorganwall commented 4 years ago

This does not seem to be an issue anymore.