search

tylernguyen / x1c6-hackintosh

READMEs, OpenCore configurations, patches, and notes for the Thinkpad X1 Carbon 6th Gen 2018 Hackintosh
https://tylernguyen.github.io/x1c6-hackintosh/
The Unlicense
626 stars 110 forks source link

Request details for how Thunderbolt Hot-Plug SSDT is implemented #127

Closed SukkaW closed 3 years ago

SukkaW commented 3 years ago

cc @benbender

I am working on implementing Thunderbolt Hot-Plug on Lenovo LEGION Y9000X 2020 Laptop, which has a very different firmware (Insyde) to ThinkPad one (Phoenix). I am interested in how you guys manage to implement SSDT that makes sysreport recognize Thunderbolt Device correctly.

Since there are many differences between ThinkPad Phoenix Firmware and Lenovo Insyde Firmware, I'd like to know how disabling ICM is implemented, and how Thunderbolt Power Management is ported.

Charlyo commented 3 years ago

+1 Would also like that. Some documentation on how the X1C6 thunderbolt was adapted to work would be appreciated @benbender .

Charlyo commented 3 years ago

@tylernguyen @benbender do you get thunderbolt devices to appear after sleep??

tylernguyen commented 3 years ago

@tylernguyen @benbender do you get thunderbolt devices to appear after sleep??

I do.

usr-sse2 commented 3 years ago

Some documentation is here: https://osy.gitbook.io/hac-mini-guide/details/thunderbolt-3-fix, but I still don't get Thunerbolt after sleep (at least without flashing a patched firmware). I posted a longer message here, but some GitHub bug deleted it when I just edited it to add a log.

lucas-www commented 3 years ago

https://www.reddit.com/r/hackintosh/comments/lz4n5c/finally_working_egpu_over_thunderbolt_3_lenovo_x1/

from this post, eGPU works well?

kushwavez commented 3 years ago

@lucas-www I was the author of that, for me Hot-Plug (and eGPU) is working. I’m using the SSDTs made by tylernguyen, but not the same Renames. It is a bit outdated on the Reddit post. I have a Clover efi repo here on GitHub, that is the up-to-date one.

In that, I have only _UPC to XUPC, _PS0 to XPS0 and _PS3 to XPS3 and _SB.PCI0.RP09._INI to XINI rename patches, and I don’t have _GPE.NTFY to XTFY because that caused not working hot-plug for me. the only cosmetic problem with that is now at System Manager there is no Thunderbolt devices detected, BUT they’re connected and you can see them at PCI Devices.

Charlyo commented 3 years ago

@kushwavez what about the rename of UBTC.NTFY to XTFY. I think rename is not present in this repo.

kushwavez commented 3 years ago

I don't use that either. Not needed. USB-C and TB3 are working without that.

One note on _GPE.NTFY to XTFY: If I use this patch, I can see the TB3 devices attached from System Manager. But sometimes the hot-plug just does not work after sleep (sometimes before too), and the notebook is waking from sleep very slowly, wifi is reconnecting (BCM94360CS2). With leaving the XTFY rename patch, the hot-plug is working okay, and the waking process also much quicker and the wifi is working okay too. But as I mentioned earlier, with leaving XTFY rename patch, at System Manager it says "No thunderbolt driver loaded", but it's cosmetic and they're connecting okay, and you can see them in PCI devices.

So right now, for me the working config for TB3 is this: Képernyőfotó 2021-06-05 - 16 25 44

This is for loading TB3 driver in System Manager (but slow wake, and sometimes not working hot-plug): Képernyőfotó 2021-06-05 - 16 34 10

It is in Clover tho, but it doesn't matter. If the TB3 is not working after sleep (totally random for me, only with eGPU), plug the device in, put the notebook to sleep, wake it up.

velaar commented 3 years ago

Are you running with or without BIOS Assist? Also which NVM firmware?

On Jun 5, 2021, at 10:36 AM, kushwavez @.***> wrote:

 I don't use that either. Not needed. USB-C and TB3 are working without that.

One note on _GPE.NTFY to XTFY: If I use this patch, I can see the TB3 devices attached from System Manager. But sometimes the hot-plug just does not work after sleep (sometimes before too), and the notebook is waking from sleep very slowly, wifi is reconnecting (BCM94360CS2). With leaving the XTFY rename patch, the hot-plug is working okay, and the waking process also much quicker and the wifi is working okay too. But as I mentioned earlier, with leaving XTFY rename patch, at System Manager it says "No thunderbolt driver loaded", but it's cosmetic and they're connecting okay, and you can see them in PCI devices.

So right now, for me the working config for TB3 is this:

This is for loading TB3 driver in System Manager (but slow wake, and sometimes not working hot-plug):

If the TB3 is not working after sleep (totally random for me, only with eGPU), plug the device in, put the notebook to sleep, wake it up.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

kushwavez commented 3 years ago

BIOS Assist disabled. If you enable BIOS assist, then you'll lose hot-plug, and the device is only working if you plug-in before start.

About NVM firmware. Latest at the time of writing, downloaded from Lenovo site: 17.0.0.18-N23TF23W.

tylernguyen commented 3 years ago

Perhaps we should move this into the discussion tab? it's not really related any particular issue

SukkaW commented 3 years ago

Perhaps we should move this into the discussion tab? it's not really related any particular issue

Not my original issue. None of those discussions is related with my issue and I am very upset of it.

tylernguyen commented 3 years ago

@SukkaW

I understand.

Additionally, it may be better to request documentation from @benbender 's repo himself. https://github.com/benbender/x1c6-hackintosh

Regardless, I will close this issue as it's gotten way off topic and I cannot really address the original issue.

I'll create a TB3/hotplug/eGPU topic under discussion.

Please go there for everything related.