search

tylernguyen / x1c6-hackintosh

READMEs, OpenCore configurations, patches, and notes for the Thinkpad X1 Carbon 6th Gen 2018 Hackintosh
https://tylernguyen.github.io/x1c6-hackintosh/
The Unlicense
636 stars 109 forks source link

plugin-type=1 doubt #45

Closed zacharysalvatore closed 4 years ago

zacharysalvatore commented 4 years ago

according to Getting-Started-With-ACPI we need to replace the default CUP0 to our PR00 in SSDT-PLUG. Our X1C6's DSDT shows that we need to replace CUP0 to _PR_.PR00, \_PR.PR00 accordingly. However your SSDT-PLUG-_PR.PR00.aml is different. I don't know which one is correct. Weirdly, both amls will result plugin-type=1. Here's yours: Here's yours Here's how it i thought it should be: Here's how it i thought it should be IORegistryExplorer 2020-04-07 at 22 01 59@2x

tylernguyen commented 4 years ago

Weirdly, both amls will result plugin-type=1.

Both are correct patches. And both will set plugin-type=1.

As for their difference, you can refer back to Getting Started with ACPI. My hotpatch is modified from the same source as SSDTTime, while the manual method is modifying its hotpatch from the sample of OpenCorePkg.

Again, they both work and there's nothing wrong or bad with either.

Feel free to use whichever one you like more.

tylernguyen commented 4 years ago

Furthermore, the reason why my patch includes the DTGP method is to check UUID. Your hotpatch will work without the DTGP method. However, real Macs uses the DTGP method. And I think that's it better for our hotpatch to mimic real Mac DSDT to prevent possible problems down the line.

zacharysalvatore commented 4 years ago

Thank you for your kind explanation.

zacharysalvatore commented 4 years ago

Furthermore, the reason why my patch includes the DTGP method is to check UUID. Your hotpatch will work without the DTGP method. However, real Macs uses the DTGP method. And I think that's it better for our hotpatch to mimic real Mac DSDT to prevent possible problems down the line.

By the way, what’s this UUID? Do I need replace this with my systemuuid?

tylernguyen commented 4 years ago

@zacharysalvatore You do not need to modify it. That UUID comes from a real Mac, see various DTGP methods in MacBook.Pro-14.1.acpi.zip