search

tylernguyen / x1c6-hackintosh

READMEs, OpenCore configurations, patches, and notes for the Thinkpad X1 Carbon 6th Gen 2018 Hackintosh
https://tylernguyen.github.io/x1c6-hackintosh/
The Unlicense
630 stars 110 forks source link

Question about acpi patching #46

Closed Jamesxxx1997 closed 4 years ago

Jamesxxx1997 commented 4 years ago

Hi~ I'm a user of thinkpad x1 yoga 2018, with its specs similar to x1 carbon 2018 I have some question about acpi patching~

  1. there is a bunch of acpi error when using the hotpatch , will this effect the system stability and cause issue? IMG_8765

  2. Do you have guide about traditional DSDT patch about x1 carbon 2018 ?

Thanks!

tylernguyen commented 4 years ago

@Jamesxxx1997 Systems specs do not determine the likeness of ACPI tables. Two machines can have similar devices but be configured as different names or paths under the ACPI table. Hence, my hotpatches will not translate well to your X1 Yoga 2018. This is especially apparent within the keyboard SSDT patch, where some of my Fn keys will most lilkely not match with yours.

Extract your source DSDT, use a diff program to compare it with my own source DSDT. And you will see how different the two tablesets are.

In addition, OpenCore does not play well with static DSDT patching. So I would recommend trying to learn SSDT hot patching instead, as it is a better solution anyway.

Since I do not have an X1 Yoga to test myself and help you. I can only point you towards what I would try:

Firstly, please carefully go through my ACPIPatching.md. It has the reasons as to why each patch is used, their corresponding OpenCore patches, and the device that the SSDT patches

Secondly, please take a look at OC-little. That repo is a great collection of reference hotplug SSDT patches that can be modified for your machine. Simply use Google Translate to read the repo's docs.

Finally, the Vanilla Laptop Guide and Getting Started with ACPI are great resources for starters to read.

Again, I do not have an X1 Yoga. So I cannot help you with the actual testing and debugging. But if you have any other general questions. Post it here and I will try my best.

Also, I cannot see the image you posted. Maybe try posting it to Imgur and linking it?

tylernguyen commented 4 years ago

I forgot to mention this. But as I optimize this repository for the X1C6, it will increasingly become more incompatible with other machines. I understand that all this ACPI talk can be daunting. But if you spend some time looking into different guides and resources, it will greatly benefit your build.

Jamesxxx1997 commented 4 years ago

@tylernguyen Sorry , I've reupload the acpi error image

About traditional static patch

Extract your source DSDT, use a diff program to compare it with my own source DSDT. And you will see how different the two tablesets are.

Thanks you again for your detailed explanation , I will do that ASAP. But now I have to prepare for a big exam and I am still using the clover and traditional static patch ; if you have time , can you help taking a look at my patch ? Just want to check whether I do anything wrong or not, Thanks. (Afraid break my machine again when turn to hotpatch , since x1 yoga is my daily driver)

I've dump my dsdt and patching it according to our guide. using these dsdt fix i. [sys] Fix _WAK Arg0 v2 ii. [sys] Fix Mutex with non-zero SyncLevel iii. [bat] Lenovo x230i iv. [sys] OS Check Fix (Windows 10) v. [sys] RTC Fix vi. [sys] IRQ Fix vii. [sys] SMBUS Fix viii. [sys] HPET Fix ix. [sys] Shutdown restart (XHC.PMEE) Fix x. Brightness dsdt Fix (F5,F6 for control brightness) xi. [usb] USB3 _PRW 0x6D Skylake (Instant wake)

and adding some hotpatch , including

  1. SSDT-PNLF
  2. SSDT-PTSWAK (from P little)
  3. SSDT-USBX
  4. SSDT-UIAC
  5. SSDT-Thinkpad_Clickpad

My efi folder