search

tylernguyen / x1c6-hackintosh

READMEs, OpenCore configurations, patches, and notes for the Thinkpad X1 Carbon 6th Gen 2018 Hackintosh
https://tylernguyen.github.io/x1c6-hackintosh/
The Unlicense
636 stars 109 forks source link

config_unmoddedBIOS.plist is much smaller than config.plist #77

Closed jeremylan closed 4 years ago

jeremylan commented 4 years ago

Describe the bug Hi, it looks like the file config_unmoddedBIOS.plist is incomplete. The modded config.plist is 39k, where the unmodded one is only 2k. Thanks

benbender commented 4 years ago

config_unmoddedBIOS.plist is indeed incomplete as it consists only of the missing part needed for those without patched bios. Simply add those parts from config_unmoddedBIOS.plist to config.plist. And don't forget to close the issue :)

jeremylan commented 4 years ago

@benbender thank you for the quick reply. I understand thanks. The documentation though is not clear at all, it is implying it's either one or the other rather than a merge so maybe it should be clearly stated. Thanks again.

benbender commented 4 years ago

I See your point, but it's not my repo. I guess, best would be if you suggest some changes to this as a merge request to this repo. Sharing is caring :) Alternatively you could open a separate Issue about the documentation problem.

// cc @tylernguyen

tylernguyen commented 4 years ago

@jeremylan @benbender I'll change the doc. Originally, I was intending to maintain 2 separate config files but I found this solution easier. Thanks for the notice.

jeremylan commented 4 years ago

No problem, thank you so much for documenting all this. I really appreciate your time.