search

tylerpearson / lazyYT

A jQuery plugin to lazy load those dang Youtube iframe videos.
Other
207 stars 86 forks source link

Options #2

Closed adam-lynch closed 10 years ago

adam-lynch commented 10 years ago

This is very handy but it would be good to be able to pass options. We should easily be able to style this however we want and or not have those !important CSS rules on the element itself.

tylerpearson commented 10 years ago

Hey Adam, I definitely agree on being able to pass options. It's on the todo list for when I get some free time.

Regarding CSS styles -- do you think it makes the most sense to move these to a separate stylesheet? Right now it's embedded simply out of convenience.

adam-lynch commented 10 years ago

@tylerpearson I might be able to contribute too.

I guess they don't have to be. They could be options too. This would save the user from another step in setting up lazyYT. But then again, a separate stylesheet probably is easier for them to manage if they want custom styles (plus it would be cleaner, separating style and JS).

If it was me, I'd like to be able to take the LESS that comes with this, or CSS if there's no LESS, and drop it in one of my own LESS files. I could take advantage of my own colour scheme using my existing colour variables, etc.

tylerpearson commented 10 years ago

Added options with https://github.com/tylerpearson/lazyYT/commit/5413597b936455e05ec5dca79f1730ea47e1e6f1

adam-lynch commented 10 years ago

As far as I can see, 5413597 just adds the ability to send extra GET params to YouTube and has nothing to do with CSS?

tylerpearson commented 10 years ago

Hey Adam, you are correct. I just moved CSS to a separate file in https://github.com/tylerpearson/lazyYT/commit/28bdd3dc5eb298457839257b42d20d5757f1074c.